Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: remove old OC Collector code #149

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

pjanotti
Copy link
Contributor

Initial phase of removal of old OC code that is still present on the repo.

  • Renamed and moved collector package to application
  • Deleted the ./cmd/occollector/ folder (and related Makefile target)
  • Removed some dead code from package builder (there is still more to be deleted, but I had to choose a cut point for this PR)
  • Moved Jaeger sender/ to exporter/ in preparation to implement issue Add Jaeger exporter factory #136 (Add Jaeger Exporter Factory)

Initial phase of removal of old OC code that is still present on the repo.
@codecov-io
Copy link

codecov-io commented Jul 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@34ca12f). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #149   +/-   ##
=========================================
  Coverage          ?   73.05%           
=========================================
  Files             ?       95           
  Lines             ?     5789           
  Branches          ?        0           
=========================================
  Hits              ?     4229           
  Misses            ?     1350           
  Partials          ?      210
Impacted Files Coverage Δ
service/telemetry.go 72.97% <ø> (ø)
service/healthcheck.go 100% <ø> (ø)
service/builder/sampling_builder.go 76.08% <ø> (ø)
...er/jaegerexporter/jaeger_thrift_tchannel_sender.go 0% <ø> (ø)
...porter/jaegerexporter/jaeger_thrift_http_sender.go 0% <ø> (ø)
receiver/zipkinreceiver/trace_receiver.go 56.22% <ø> (ø)
service/builder/processor_builder.go 87.3% <ø> (ø)
service/builder/pipelines_builder.go 92.72% <ø> (ø)
...xporter/jaegerexporter/jaeger_proto_grpc_sender.go 0% <ø> (ø)
service/logger.go 80% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ca12f...56ca0c8. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment.

application/application.go Outdated Show resolved Hide resolved
@pjanotti pjanotti merged commit 4c7c3ca into open-telemetry:master Jul 11, 2019
@pjanotti pjanotti deleted the refactor-move-application branch July 11, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants