Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor obsreport, check for new metrics, change all code to check for new metrics #1299

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #1299 into master will decrease coverage by 0.05%.
The diff coverage is 95.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1299      +/-   ##
==========================================
- Coverage   89.40%   89.34%   -0.06%     
==========================================
  Files         212      212              
  Lines       15152    15144       -8     
==========================================
- Hits        13546    13530      -16     
- Misses       1171     1178       +7     
- Partials      435      436       +1     
Impacted Files Coverage Δ
obsreport/observability.go 100.00% <ø> (ø)
obsreport/obsreporttest/obsreporttest.go 95.58% <94.54%> (-4.42%) ⬇️
obsreport/obsreport.go 95.00% <100.00%> (+0.26%) ⬆️
obsreport/obsreport_exporter.go 97.93% <100.00%> (-0.09%) ⬇️
obsreport/obsreport_receiver.go 100.00% <100.00%> (ø)
exporter/exporterhelper/metricshelper.go 85.71% <0.00%> (-7.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ecc3a1...64dc1a6. Read the comment docs.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the cut & paste error.

obsreport/obsreport_receiver.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 4272781 into open-telemetry:master Jul 9, 2020
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
@bogdandrutu bogdandrutu deleted the obsrepref branch September 22, 2020 21:02
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Check marshalled value

Signed-off-by: Daniil Rutskiy <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Daniil Rutskiy <[email protected]>

* Move change to Fixed section

Signed-off-by: Daniil Rutskiy <[email protected]>

Co-authored-by: Tyler Yahn <[email protected]>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants