Change Queue interface to return a callback instead of an index #12230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
done-callback
branch
2 times, most recently
from
bb7ff47 to
eda2037
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12230 +/- ##
==========================================
+ Coverage 91.23% 91.30% +0.07%
==========================================
Files 466 464 -2
Lines 25656 25662 +6
==========================================
+ Hits 23406 23430 +24
+ Misses 1837 1819 -18
Partials 413 413 ☔ View full report in Codecov by Sentry. |
bogdandrutu
force-pushed
the
done-callback
branch
from
eda2037 to
dfdb3ad
Compare
dmitryax
approved these changes
Jan 31, 2025
bogdandrutu
force-pushed
the
done-callback
branch
2 times, most recently
from
b441177 to
6c5a499
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
done-callback
branch
from
6c5a499 to
9be07e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow to simplify significantly the implementation for when queue is disabled and caller must block until the batch is constructed and processed downstream
Updates #8122
It is ok to have this as a breaking change since Queue is still experimental.