Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processorhelper] add processorhelperprofiles package #11556

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

haoqixu
Copy link
Member

@haoqixu haoqixu commented Oct 29, 2024

Description

Add processorhelperprofiles to support profiles signal.

cc @mx-psi @dmathieu

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.46%. Comparing base (90243f3) to head (2d168fc).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...rocessorhelper/processorhelperprofiles/profiles.go 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11556      +/-   ##
==========================================
- Coverage   91.47%   91.46%   -0.02%     
==========================================
  Files         435      440       +5     
  Lines       23757    23887     +130     
==========================================
+ Hits        21732    21848     +116     
- Misses       1648     1660      +12     
- Partials      377      379       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoqixu haoqixu force-pushed the add-pkg-processorhelperprofiles branch 2 times, most recently from bf063fc to bf13d0c Compare October 29, 2024 07:48
@haoqixu haoqixu force-pushed the add-pkg-processorhelperprofiles branch from bf13d0c to 4a78e36 Compare October 29, 2024 07:51
@dmathieu
Copy link
Member

This PR introduces a new module. I think it should include a changelog entry (and not be a chore).

@haoqixu haoqixu changed the title [chore] add processorhelperprofiles package [processorhelper] add processorhelperprofiles package Oct 29, 2024
@haoqixu haoqixu force-pushed the add-pkg-processorhelperprofiles branch from 24f7a7f to 34eb381 Compare October 29, 2024 10:11
@mx-psi mx-psi merged commit 002a748 into open-telemetry:main Oct 29, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 29, 2024
@mx-psi
Copy link
Member

mx-psi commented Oct 29, 2024

@haoqixu To be able to use this package in contrib, you need to run make update-otel to update to the latest commit (002a748). The process can be a bit fragile and need manual steps, feel free to reach out on #otel-collector-dev on the CNCF Slack for help!

djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
…#11556)

#### Description
Add `processorhelperprofiles` to support profiles signal.

cc @mx-psi @dmathieu

---------

Co-authored-by: Florian Bacher <[email protected]>
Co-authored-by: Damien Mathieu <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
…#11556)

#### Description
Add `processorhelperprofiles` to support profiles signal.

cc @mx-psi @dmathieu

---------

Co-authored-by: Florian Bacher <[email protected]>
Co-authored-by: Damien Mathieu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants