Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processorhelper] Fix bug where record in/out metrics were skipped #11360

Merged

Conversation

djaglowski
Copy link
Member

Resolves #11351

@djaglowski djaglowski mentioned this pull request Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (403f1df) to head (3cbbaaf).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11360      +/-   ##
==========================================
+ Coverage   91.52%   91.78%   +0.25%     
==========================================
  Files         428      432       +4     
  Lines       20233    20423     +190     
==========================================
+ Hits        18519    18746     +227     
+ Misses       1339     1302      -37     
  Partials      375      375              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djaglowski
Copy link
Member Author

The contrib test failure appears to be expected with this change. The filter processor returns ErrSkipProcessingData if it filtered all data points, which happens in the test. Previously this caused a single data point to not be counted as incoming.

@djaglowski djaglowski marked this pull request as ready for review October 4, 2024 14:14
@djaglowski djaglowski requested a review from a team as a code owner October 4, 2024 14:14
@djaglowski djaglowski requested a review from bogdandrutu October 4, 2024 14:14
@bogdandrutu
Copy link
Member

There are lint issues.

@djaglowski djaglowski force-pushed the processorhelper-in-out-fix branch from 26ba86b to 3cbbaaf Compare October 4, 2024 19:08
@bogdandrutu bogdandrutu merged commit c3f09f4 into open-telemetry:main Oct 4, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 4, 2024
@dmitryax
Copy link
Member

dmitryax commented Oct 5, 2024

@djaglowski do you have a fix for the tests on contrib side by chance?

@djaglowski
Copy link
Member Author

I'll update core and make the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processor In/Out metrics not recorded if process func fails (even for skipping next component)
3 participants