-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processorhelper] Fix bug where record in/out metrics were skipped #11360
[processorhelper] Fix bug where record in/out metrics were skipped #11360
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11360 +/- ##
==========================================
+ Coverage 91.52% 91.78% +0.25%
==========================================
Files 428 432 +4
Lines 20233 20423 +190
==========================================
+ Hits 18519 18746 +227
+ Misses 1339 1302 -37
Partials 375 375 ☔ View full report in Codecov by Sentry. |
The contrib test failure appears to be expected with this change. The filter processor returns |
There are lint issues. |
26ba86b
to
3cbbaaf
Compare
@djaglowski do you have a fix for the tests on contrib side by chance? |
I'll update core and make the fix. |
Resolves #11351