Fix data race condition, concurrent writes to the err variable, causes Undefined Behavior #11349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s UB Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
fix-ub-proc-helper
branch
from
4b2d190 to
b591926
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11349 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 428 428
Lines 20230 20233 +3
=======================================
+ Hits 18519 18522 +3
Misses 1337 1337
Partials 374 374 ☔ View full report in Codecov by Sentry. |
bogdandrutu
added
the
release:blocker
codeboten
approved these changes
Oct 4, 2024
MovieStoreGuy
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
I am honestly surprised that the golangci-lint or the race detector didn't catch this.
The other way you could resolve this is by having a named returned value for the lambda being created so that would shadow the error previously defined. However, this would be flagged by the shadow linter.
Alternatively, discourage anonymous functions being declared within methods could also be another way to stop this from occurring again in the project?
bogdandrutu
changed the title
bogdandrutu
commented
Oct 4, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
…s Undefined Behavior (open-telemetry#11349) The main issue is that after open-telemetry#10910 the err variable is shared between requests because it uses the same address as the err defined outside the func. This is an UB because we are overwriting memory and will cause crashes like open-telemetry#11335, where the check for not nil happens then gets overwrite with nil and crashes. Fixes open-telemetry#11350 --------- Signed-off-by: Bogdan Drutu <[email protected]>
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…s Undefined Behavior (open-telemetry#11349) The main issue is that after open-telemetry#10910 the err variable is shared between requests because it uses the same address as the err defined outside the func. This is an UB because we are overwriting memory and will cause crashes like open-telemetry#11335, where the check for not nil happens then gets overwrite with nil and crashes. Fixes open-telemetry#11350 --------- Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue is that after #10910 the err variable is shared between requests because it uses the same address as the err defined outside the func.
This is an UB because we are overwriting memory and will cause crashes like #11335, where the check for not nil happens then gets overwrite with nil and crashes.
Fixes #11350