[chore] docs(builder): remove outdated note on builder version reporting #11261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11261 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 424 424
Lines 20188 20188
=======================================
Hits 18456 18456
Misses 1348 1348
Partials 384 384 ☔ View full report in Codecov by Sentry. |
songy23
approved these changes
Sep 24, 2024
|
Have you tested it? I am confused about #11208 then? |
|
I think #11208 is a different issue, that PR is about respecting the version number once it is set. This PR is about the (already fixed) incorrect version format. |
@bogdandrutu Yes, I tested it with v0.109.0 and v0.110.0. $ go install go.opentelemetry.io/collector/cmd/[email protected]
$ builder version
ocb version v0.110.0
$ go install go.opentelemetry.io/collector/cmd/[email protected]
$ builder version
ocb version v0.109.0
$ go install go.opentelemetry.io/collector/cmd/builder@latest
$ builder version
ocb version v0.110.0 |
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
…ing (open-telemetry#11261) This has been fixed since v0.91.0: open-telemetry#8994.
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…ing (open-telemetry#11261) This has been fixed since v0.91.0: open-telemetry#8994.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been fixed since v0.91.0: #8994.