[chore]: enable compares and negative-positive rules from testifylint #11128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
testifylint/compares
branch
from
c4b8131 to
b2b7ce7
Compare
bogdandrutu
approved these changes
Sep 10, 2024
codeboten
approved these changes
Sep 10, 2024
mmorel-35
force-pushed
the
testifylint/compares
branch
from
b2b7ce7 to
8a4200a
Compare
mmorel-35
changed the title
mmorel-35
force-pushed
the
testifylint/compares
branch
2 times, most recently
from
67a68b1 to
08c7d1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11128 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 414 414
Lines 19810 19810
=======================================
Hits 18271 18271
Misses 1167 1167
Partials 372 372 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
testifylint/compares
branch
from
08c7d1b to
69658c7
Compare
songy23
approved these changes
Sep 11, 2024
|
Test failure is a known issue #10927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testifylint is a linter that provides best practices with the use of testify.
This PR enables compares and negative-positive rules from testifylint