Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: enable error-nil and nil-compare rules from testifylint #11120

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

Testifylint is a linter that provides best practices with the use of testify.

This PR enables error-nil and nil-compare rules from testifylint

@mmorel-35 mmorel-35 requested review from a team and evan-bradley September 10, 2024 19:18
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (65bebec) to head (2eeac37).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11120   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         414      414           
  Lines       19810    19810           
=======================================
  Hits        18271    18271           
  Misses       1167     1167           
  Partials      372      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Sep 10, 2024
@bogdandrutu bogdandrutu merged commit 2720f59 into open-telemetry:main Sep 10, 2024
66 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 10, 2024
@mmorel-35 mmorel-35 deleted the testifylint/nil-compare branch September 10, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants