-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confmap] Set confmap.unifyEnvVarExpansion feature gate to stable #10508
Merged
dmitryax
merged 20 commits into
open-telemetry:main
from
TylerHelmuth:unify-env-var-gate-stable
Aug 7, 2024
+250
−452
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
37f7fba
Set confmap.unifyEnvVarExpansion feature gate to stable
TylerHelmuth c57a49f
changelog
TylerHelmuth 62616c6
fix some tests
TylerHelmuth 04d0ce9
fix another test
TylerHelmuth 7ca2e48
make gotidy
TylerHelmuth 26880df
Move $$ escaping back to Resolver
TylerHelmuth 315de42
make gotidy
TylerHelmuth 067d3f1
make crosslink
TylerHelmuth 6caabcd
Merge remote-tracking branch 'upstream/main' into unify-env-var-gate-…
TylerHelmuth e2167ad
support escaping in nested expansions
TylerHelmuth eac5873
Fix lint
TylerHelmuth d5dcc55
Dont escape original value
TylerHelmuth 14eee2e
Improve test
TylerHelmuth 6dbef43
Escape expandValue.Original
TylerHelmuth cce672d
Fix comment test
TylerHelmuth fd8ca4b
Apply suggestions from code review
TylerHelmuth 95126d3
Merge branch 'unify-env-var-gate-stable' of https://github.com/TylerH…
TylerHelmuth 54cddc3
Update confmap/internal/e2e/expand_test.go
TylerHelmuth 87fa185
Merge branch 'main' into unify-env-var-gate-stable
TylerHelmuth bebb922
Update internal/globalgates/globalgates.go
TylerHelmuth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: breaking | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) | ||
component: confmap | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Set the `confmap.unifyEnvVarExpansion` feature gate to Stable. Expansion of `$FOO` env vars is no longer supported. Use `${FOO}` or `${env:FOO}` instead. | ||
|
||
# One or more tracking issues or pull requests related to the change | ||
issues: [10508] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | ||
|
||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [] |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the feature gate stable negates these tests, which set the gate to false. Since the module is being deprecated, and will be removed shortly after, removing the tests doesn't feel like a big deal.