Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configgrpc] Revert to third-party compressor for zstd #10394

Conversation

jpkrohling
Copy link
Member

We switched back to our compression logic for zstd when a CVE was found on the third-party library we were using. Now that the third-party library has been fixed, we can revert to that one. For end-users, this has no practical effect. The reproducers for the CVE were tested against this patch, confirming we are not reintroducing the bugs.

Signed-off-by: Juraci Paixão Kröhling [email protected]

@jpkrohling jpkrohling requested review from a team and songy23 June 12, 2024 14:26
@jpkrohling jpkrohling force-pushed the jpkrohling/switch-back-to-go-grpc-compression-for-zstd branch from 38c69d1 to d77f4a6 Compare June 12, 2024 14:27
@jpkrohling jpkrohling force-pushed the jpkrohling/switch-back-to-go-grpc-compression-for-zstd branch from d77f4a6 to 2d88482 Compare June 12, 2024 14:29
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs make gotidy

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.55%. Comparing base (e4a1f5b) to head (fbf21f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10394      +/-   ##
==========================================
+ Coverage   92.53%   92.55%   +0.01%     
==========================================
  Files         388      387       -1     
  Lines       18317    18284      -33     
==========================================
- Hits        16949    16922      -27     
+ Misses       1022     1017       -5     
+ Partials      346      345       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@codeboten codeboten merged commit 3996c58 into open-telemetry:main Jun 12, 2024
48 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants