Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/go-viper/mapstructure/v2 to v2.0.0 - abandoned #10300

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 4, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/go-viper/mapstructure/v2 v2.0.0-alpha.1 -> v2.0.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

go-viper/mapstructure (github.com/go-viper/mapstructure/v2)

v2.0.0

Compare Source

mapstructure v2 release 🎉🎉🎉🎉
⚠️ Breaking changes
  • Error is removed in favor of errors.Join (backported from Go 1.20 to preserve compatibility with earlier versions)
What's Changed
New Contributors

Full Changelog: go-viper/mapstructure@v1.6.0...v2.0.0


Configuration

📅 Schedule: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file renovatebot labels Jun 4, 2024
@renovate renovate bot requested review from a team and songy23 June 4, 2024 00:35
songy23
songy23 previously approved these changes Jun 4, 2024
@songy23 songy23 dismissed their stale review June 4, 2024 13:32

failed CI

@songy23
Copy link
Member

songy23 commented Jun 4, 2024

Breaking changes:

--- FAIL: TestValidate (11.61s)
    --- FAIL: TestValidate/testdata/invalid_stability.yaml (0.00s)
        validate_test.go:104: 
            	Error Trace:	D:/a/opentelemetry-collector/opentelemetry-collector/cmd/mdatagen/validate_test.go:104
            	Error:      	Error message not equal:
            	            	expected: "1 error(s) decoding:\n\n* error decoding 'status.stability': invalid stability level: incorrectstability"
            	            	actual  : "decoding failed due to the following error(s):\n\nerror decoding 'status.stability': invalid stability level: incorrectstability"
            	Test:       	TestValidate/testdata/invalid_stability.yaml
FAIL

@codeboten
Copy link
Contributor

Spent some time on this one. There's some messages that end up reporting an additional empty error:

expected: "decoding failed due to the following error(s):\n\nerror decoding 'err': never works"
actual  : "decoding failed due to the following error(s):\n\nerror decoding '': decoding failed due to the following error(s):\n\nerror decoding 'err': never works"

It's unclear to me why

Copy link
Contributor

github-actions bot commented Jul 3, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 3, 2024
@atoulme
Copy link
Contributor

atoulme commented Jul 14, 2024

Spent some time on this one. There's some messages that end up reporting an additional empty error:

expected: "decoding failed due to the following error(s):\n\nerror decoding 'err': never works"
actual  : "decoding failed due to the following error(s):\n\nerror decoding '': decoding failed due to the following error(s):\n\nerror decoding 'err': never works"

It's unclear to me why

it's because an intermediate call to Unmarshal happens on the outer struct.

@atoulme
Copy link
Contributor

atoulme commented Jul 14, 2024

I would like to close this PR in favor of #10610

@github-actions github-actions bot removed the Stale label Jul 17, 2024
mx-psi pushed a commit that referenced this pull request Jul 19, 2024
#### Description
Reprises
#10300

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Fixed a few tests that no longer make sense. One test will conflict if
#10609 is
merged first.
@renovate renovate bot changed the title Update module github.com/go-viper/mapstructure/v2 to v2.0.0 Update module github.com/go-viper/mapstructure/v2 to v2.0.0 - abandoned Jul 19, 2024
Copy link
Contributor Author

renovate bot commented Jul 19, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@atoulme atoulme closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file renovatebot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants