-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Remove unused ocRegistry, no longer used #10215
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10215 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 361 361
Lines 16964 16965 +1
=======================================
+ Hits 15606 15607 +1
Misses 1019 1019
Partials 339 339 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the ocregistry was still used by some of the contrib components that use opencensus, is that no longer the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stats module in opencensus it is it own producer registered, this registry was only for the process metrics :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I was confusing this producer registration for the one in the exporter configuration
otelprom.WithProducer(opencensus.NewMetricProducer()), |
No description provided.