Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forward connector: fails validation across pipelines #7892

Closed
MovieStoreGuy opened this issue Jun 14, 2023 · 2 comments
Closed

forward connector: fails validation across pipelines #7892

MovieStoreGuy opened this issue Jun 14, 2023 · 2 comments
Assignees
@djaglowski
Labels
area:connector bug Something isn't working priority:p2 Medium

Comments

@MovieStoreGuy
Copy link
Contributor

Describe the bug
it is possible for a shared reference a forward connector to fail validation due it being used across pipelines

Steps to reproduce

Have two different telemetry pipelines that share the forward reference, ie:

service:
  pipelines:
    metrics/receiving:
      receivers:  [nop]
      processors: []
      exporters:  [forward]
    metrics/exporting:
      receivers:  [forward]
      processors: []
      exporters:  [nop]
    traces/receiving:
      receivers:  [nop]
      processors: []
      exporters:  [forward]
    traces/exporting:
      receivers:  [forward]
      processors: []
      exporters:  [nop]

What did you expect to see?
This should start up without issue

What did you see instead?
An error occurred during the validation step:

Error: failed to build pipelines: connector "forward" cannot connect from metrics to logs: telemetry type is not supported
2023/06/14 10:41:50 collector server run finished with error: failed to build pipelines: connector "forward" cannot connect from metrics to logs: telemetry type is not supported

What version did you use?
Version: v0.79.0

What config did you use?
Shared above

Environment
OS: docker linux/arm
Compiler: go 1.20.5
@MovieStoreGuy MovieStoreGuy added the bug Something isn't working label Jun 14, 2023
@mx-psi
Copy link
Member

mx-psi commented Jun 14, 2023

I am putting a p2 priority on this one since we have a workaround (create separate instances of the connector) and it's not (I think) a regression

@djaglowski djaglowski self-assigned this Jun 20, 2023
This was referenced Jun 29, 2023
Closed
Merged
codeboten pushed a commit that referenced this issue Jul 10, 2023
@djaglowski
Fix connector validation based on usage in pipelines (#8004)
e1d0f26 
Alternate to
#8003

Fixes
##7892

Validation of connectors was too aggressive such that a connector that
was used in any combination of unsupported roles would fail. Instead,
validation should pass as long as each use of the connector has a
supported corresponding use.

For example, the forward connector may forward traces and metrics at the
same time. Previously, validation would fail because it detected that
traces->metrics and metrics->traces were possible connections. Now it
will pass as long as there is a supported connection type for each
pipeline in which the connector is used.
@djaglowski
Copy link
Member

Resolved by #8004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djaglowski djaglowski

Labels
area:connector bug Something isn't working priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@djaglowski @mx-psi @MovieStoreGuy