Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying Collector's own Resource in the config #5398

Closed
Tracked by #4231
tigrannajaryan opened this issue May 19, 2022 · 0 comments · Fixed by #5402
Closed
Tracked by #4231

Allow specifying Collector's own Resource in the config #5398

tigrannajaryan opened this issue May 19, 2022 · 0 comments · Fixed by #5402

Comments

@tigrannajaryan
Copy link
Member

In order to allow external Supervisor to control the Collector we want to the Supervisor to be able to tell the Collector to use a specific service.instance.id instead of auto-generating one.

One of the ways to allow this is to add a sub-section in the service.telemetry config section where any Resource attributes can be specified. This allow to specify not only service.instance.id, but also service.namespace (to .g. specify the team this Collector belongs too) or deployment.environment or even the service.name (defaults to current "io.opentelemetry.collector").

For example we can have the following in the config:

service:
  telemetry:
    resource:
      service.instance.id: 01G3EN4NW306AFVGQT5ZYC0GEK
      service.namespace: onlineshop
      deployment.environment: production
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue May 19, 2022
@tigrannajaryan
Create simple Supervisor example
feedb95 
- The Supervisor can manage OpenTelemetry Collector.
- Demonstrates basic features: applying config, configuring Collector to collect its own metrics.

TODO:
- Find a way to fetch Collector version instead of hard-coding it.
- Set instance id in the Collector config file to make sure OpAMP and Collector
  metrics use the same instance id.
  (Related open issue open-telemetry/opentelemetry-collector#5398)
- Re-think callbacks to avoid unnecessary restarts
  (See open-telemetry#77)
- Add a way for Supervisor to understand why the Collector process exited unexpectedly.
This was referenced May 19, 2022
Merged
Closed
Closed
@tigrannajaryan tigrannajaryan changed the title Allow to specify Collector's own Resource in the config Allow specifying Collector's own Resource in the config May 19, 2022
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-collector that referenced this issue May 19, 2022
@tigrannajaryan
Allow specifying Collector's own Resource in the config
1e74451 
Resolves open-telemetry#5398

This adds a sub-section in the `service.telemetry` config section where any
Resource attributes can be specified.

For example we can have the following in the config:

service:
  telemetry:
    resource:
      service.instance.id: 01G3EN4NW306AFVGQT5ZYC0GEK
      service.namespace: onlineshop
      deployment.environment: production
@tigrannajaryan tigrannajaryan mentioned this issue May 19, 2022
Merged
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-collector that referenced this issue May 19, 2022
@tigrannajaryan
Allow specifying Collector's own Resource in the config
39c367d 
Resolves open-telemetry#5398

This adds a sub-section in the `service.telemetry` config section where any
Resource attributes can be specified.

For example we can have the following in the config:

service:
  telemetry:
    resource:
      service.instance.id: 01G3EN4NW306AFVGQT5ZYC0GEK
      service.namespace: onlineshop
      deployment.environment: production
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-collector that referenced this issue May 20, 2022
@tigrannajaryan
Allow specifying Collector's own Resource in the config
d05c00a 
Resolves open-telemetry#5398

This adds a sub-section in the `service.telemetry` config section where any
Resource attributes can be specified.

For example we can have the following in the config:

service:
  telemetry:
    resource:
      service.instance.id: 01G3EN4NW306AFVGQT5ZYC0GEK
      service.namespace: onlineshop
      deployment.environment: production
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-collector that referenced this issue May 25, 2022
@tigrannajaryan
Allow specifying Collector's own Resource in the config
a5bd0fd 
Resolves open-telemetry#5398

This adds a sub-section in the `service.telemetry` config section where any
Resource attributes can be specified.

For example we can have the following in the config:

service:
  telemetry:
    resource:
      service.instance.id: 01G3EN4NW306AFVGQT5ZYC0GEK
      service.namespace: onlineshop
      deployment.environment: production
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue May 25, 2022
@tigrannajaryan
Create simple Supervisor example
42220b9 
- The Supervisor can manage OpenTelemetry Collector.
- Demonstrates basic features: applying config, configuring Collector to collect its own metrics.

TODO:
- Find a way to fetch Collector version instead of hard-coding it.
- Set instance id in the Collector config file to make sure OpAMP and Collector
  metrics use the same instance id.
  (Related open issue open-telemetry/opentelemetry-collector#5398)
- Re-think callbacks to avoid unnecessary restarts
  (See open-telemetry#77)
- Add a way for Supervisor to understand why the Collector process exited unexpectedly.
tigrannajaryan added a commit to tigrannajaryan/opamp-go that referenced this issue May 25, 2022
@tigrannajaryan
Create simple Supervisor example
b971ffe 
- The Supervisor can manage OpenTelemetry Collector.
- Demonstrates basic features: applying config, configuring Collector to collect its own metrics.

TODO:
- Find a way to fetch Collector version instead of hard-coding it.
- Set instance id in the Collector config file to make sure OpAMP and Collector
  metrics use the same instance id.
  (Related open issue open-telemetry/opentelemetry-collector#5398)
- Re-think callbacks to avoid unnecessary restarts
  (See open-telemetry#77)
- Add a way for Supervisor to understand why the Collector process exited unexpectedly.
tigrannajaryan added a commit to open-telemetry/opamp-go that referenced this issue May 25, 2022
@tigrannajaryan
Create simple Supervisor example (#78)
b655f04 
- The Supervisor can manage OpenTelemetry Collector.
- Demonstrates basic features: applying config, configuring Collector to collect its own metrics.

TODO:
- Find a way to fetch Collector version instead of hard-coding it.
- Set instance id in the Collector config file to make sure OpAMP and Collector
  metrics use the same instance id.
  (Related open issue open-telemetry/opentelemetry-collector#5398)
- Re-think callbacks to avoid unnecessary restarts
  (See #77)
- Add a way for Supervisor to understand why the Collector process exited unexpectedly.
tigrannajaryan added a commit that referenced this issue May 26, 2022
@tigrannajaryan
Allow specifying Collector's own Resource in the config (#5402)
87abc21 
Resolves #5398

This adds a sub-section in the `service.telemetry` config section where any
Resource attributes can be specified.

For example we can have the following in the config:

service:
  telemetry:
    resource:
      service.instance.id: 01G3EN4NW306AFVGQT5ZYC0GEK
      service.namespace: onlineshop
      deployment.environment: production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow specifying Collector's own Resource in the config tigrannajaryan/opentelemetry-collector
1 participant
@tigrannajaryan