Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make component interfaces uniform #477

Closed
tigrannajaryan opened this issue Jan 3, 2020 · 0 comments · Fixed by #488
Closed

Make component interfaces uniform #477

tigrannajaryan opened this issue Jan 3, 2020 · 0 comments · Fixed by #488

Comments

@tigrannajaryan
Copy link
Member

We have a couple inconsistenses in our component interfaces that we need to fix:

  1. Need to add a Start function to processors.
  2. Need to replace StartTraceReception/StartMetricsReception by single Start function for receivers.
  3. Need to replace StopTraceReception/StopMetricsReception by single Shutdown function for receivers.

Motivation:

  1. Uniformness results in reduction of code that currently has to deal with differences.
  2. Processor.Start is missing and is important for allowing processors to communicate with the Host.

Here is one possible approach:

  1. Introduce Component interface with Start and Shutdown functions and embed this interface in Receiver, Exporter, Processor, Extension interfaces.
  2. Have one Host interface that is used by Component.Start function.

Note that we will need to declare this change on Gitter and in SIG meetings since it is a breaking change for components and contrib component authors need to modify there components accordingly.
This was referenced Jan 3, 2020
Closed
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jan 6, 2020
Make component interfaces uniform
e9e0317 
This change fixes inconsistencies in component interfaces. Motivation:

- Uniformness results in reduction of code that currently has to
  deal with differences.
- Processor.Start is missing and is important for allowing processors
  to communicate with the Host.

What's changed:

- Introduced Component interface.
- Unified Host interface.
- Added a Start function to processors (via Component interface).
- Start/Shutdown is now called for Processors from service start/shutdown.
- Receivers, Exporters, Processors, Extensions now embed Component interface.
- Replaced StartTraceReception/StartMetricsReception by single Start function for receivers.
- Replaced StopTraceReception/StopMetricsReception by single Shutdown function for receivers.

Note: before merging this we need to announce the change in Gitter since it
breaks existing implementations in contrib (although the fix is easy).

Resolves open-telemetry#477
Resolves open-telemetry#262
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jan 6, 2020
Make component interfaces uniform
dc8d621 
This change fixes inconsistencies in component interfaces. Motivation:

- Uniformness results in reduction of code that currently has to
  deal with differences.
- Processor.Start is missing and is important for allowing processors
  to communicate with the Host.

What's changed:

- Introduced Component interface.
- Unified Host interface.
- Added a Start function to processors (via Component interface).
- Start/Shutdown is now called for Processors from service start/shutdown.
- Receivers, Exporters, Processors, Extensions now embed Component interface.
- Replaced StartTraceReception/StartMetricsReception by single Start function for receivers.
- Replaced StopTraceReception/StopMetricsReception by single Shutdown function for receivers.

Note: before merging this we need to announce the change in Gitter since it
breaks existing implementations in contrib (although the fix is easy).

Resolves open-telemetry#477
Resolves open-telemetry#262
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jan 8, 2020
Make component interfaces uniform
4f02aeb 
This change fixes inconsistencies in component interfaces. Motivation:

- Uniformness results in reduction of code that currently has to
  deal with differences.
- Processor.Start is missing and is important for allowing processors
  to communicate with the Host.

What's changed:

- Introduced Component interface.
- Unified Host interface.
- Added a Start function to processors (via Component interface).
- Start/Shutdown is now called for Processors from service start/shutdown.
- Receivers, Exporters, Processors, Extensions now embed Component interface.
- Replaced StartTraceReception/StartMetricsReception by single Start function for receivers.
- Replaced StopTraceReception/StopMetricsReception by single Shutdown function for receivers.

Note: before merging this we need to announce the change in Gitter since it
breaks existing implementations in contrib (although the fix is easy).

Resolves open-telemetry#477
Resolves open-telemetry#262
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jan 8, 2020
Make component interfaces uniform
7399146 
This change fixes inconsistencies in component interfaces. Motivation:

- Uniformness results in reduction of code that currently has to
  deal with differences.
- Processor.Start is missing and is important for allowing processors
  to communicate with the Host.

What's changed:

- Introduced Component interface.
- Unified Host interface.
- Added a Start function to processors (via Component interface).
- Start/Shutdown is now called for Processors from service start/shutdown.
- Receivers, Exporters, Processors, Extensions now embed Component interface.
- Replaced StartTraceReception/StartMetricsReception by single Start function for receivers.
- Replaced StopTraceReception/StopMetricsReception by single Shutdown function for receivers.

Note: before merging this we need to announce the change in Gitter since it
breaks existing implementations in contrib (although the fix is easy).

Resolves open-telemetry#477
Resolves open-telemetry#262
tigrannajaryan added a commit that referenced this issue Jan 10, 2020
@tigrannajaryan
Make component interfaces uniform (#488)
91728bc 
This change fixes inconsistencies in component interfaces. Motivation:

- Uniformness results in reduction of code that currently has to
  deal with differences.
- Processor.Start is missing and is important for allowing processors
  to communicate with the Host.

What's changed:

- Introduced Component interface.
- Unified Host interface.
- Added a Start function to processors (via Component interface).
- Start/Shutdown is now called for Processors from service start/shutdown.
- Receivers, Exporters, Processors, Extensions now embed Component interface.
- Replaced StartTraceReception/StartMetricsReception by single Start function for receivers.
- Replaced StopTraceReception/StopMetricsReception by single Shutdown function for receivers.

Note: before merging this we need to announce the change in Gitter since it
breaks existing implementations in contrib (although the fix is easy).

Resolves #477
Resolves #262
subnova pushed a commit to subnova/opentelemetry-collector that referenced this issue Jan 14, 2020
@tigrannajaryan @subnova-etsy
Make component interfaces uniform (open-telemetry#488)
ba03d67 
This change fixes inconsistencies in component interfaces. Motivation:

- Uniformness results in reduction of code that currently has to
  deal with differences.
- Processor.Start is missing and is important for allowing processors
  to communicate with the Host.

What's changed:

- Introduced Component interface.
- Unified Host interface.
- Added a Start function to processors (via Component interface).
- Start/Shutdown is now called for Processors from service start/shutdown.
- Receivers, Exporters, Processors, Extensions now embed Component interface.
- Replaced StartTraceReception/StartMetricsReception by single Start function for receivers.
- Replaced StopTraceReception/StopMetricsReception by single Shutdown function for receivers.

Note: before merging this we need to announce the change in Gitter since it
breaks existing implementations in contrib (although the fix is easy).

Resolves open-telemetry#477
Resolves open-telemetry#262
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Add support for translating collectd monitors (open-telemetry#477)
eafbdc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make component interfaces uniform tigrannajaryan/opentelemetry-collector
1 participant
@tigrannajaryan