Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform ComponentDocs into a "command" #2664

Closed
bogdandrutu opened this issue Mar 10, 2021 · 4 comments
Closed

Transform ComponentDocs into a "command" #2664

bogdandrutu opened this issue Mar 10, 2021 · 4 comments
Assignees
@mxiamxia
Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Milestone
Phase1-Trace-GA-R...

Comments

@bogdandrutu
Copy link
Member

Right now this is a test in componenttest, but it will be good to have this as a binary that we can run as standalone and limit the public API we expose.

This binary can take as flags the arguments needed in the current API.
@bogdandrutu bogdandrutu added this to the Phase1-GA-Roadmap milestone Mar 10, 2021
@bogdandrutu bogdandrutu assigned asuresh4 and unassigned asuresh4 Mar 10, 2021
@bogdandrutu bogdandrutu added good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up labels Mar 11, 2021
@alolita
Copy link
Member

alolita commented Mar 11, 2021

@bogdandrutu can you please assign @mxiamxia to this issue - I don't have rights to assign. Thanks!

@bogdandrutu
Copy link
Member Author

@mxiamxia before you apply to become member of the org can you comment something on this issue so I can assign to you?

@mxiamxia
Copy link
Member

@mxiamxia before you apply to become member of the org can you comment something on this issue so I can assign to you?

Thanks @bogdandrutu, sent the member request - open-telemetry/community#677

@mxiamxia mxiamxia mentioned this issue Mar 15, 2021
Merged
3 tasks
@mxiamxia
Copy link
Member

mxiamxia commented Mar 15, 2021 •
edited
Loading

Convert CheckDocs from componenttest to the standalone command tool and remove the checks from unit test in service module to minimize the exposed API.

  • Convert CheckDocs to binary command tool in Core repository, add it in workflow check and remove related check from unit test
  • Import CheckDocs tool in Contrib repository, add it in workflow check and remove related check from unit test.
  • Delete docs.go and docs_test.go files from componenttest in Core repository

This was referenced Mar 15, 2021
Merged
Merged
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@dependabot
Bump boto3 in /internal/buildscripts/packaging/release (open-telemetr…
4eb0c37 
…y#2664)

Bumps [boto3](https://github.com/boto/boto3) from 1.26.79 to 1.26.84.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.26.79...1.26.84)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@marcalff
[API/SDK] Provider cleanup (open-telemetry#2664)
2535c70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxiamxia mxiamxia

Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
Phase1-Trace-GA-Roadmap
Development

No branches or pull requests
4 participants
@bogdandrutu @alolita @mxiamxia @asuresh4