-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove builder support to build old version #11405
Labels
Comments
@mx-psi here is a followup on how we can remove a lot of complications, and I believe is reasonable to have this and we can have much better checks, etc. |
We have #9366, agreed that this is something we want to do |
Looks like I am consistent :)))) |
This was referenced Oct 29, 2024
bogdandrutu
added a commit
that referenced
this issue
Oct 30, 2024
Updates #11405 Signed-off-by: Bogdan Drutu <[email protected]>
This was referenced Nov 1, 2024
jburns24
added a commit
to liatrio/liatrio-otel-collector
that referenced
this issue
Nov 8, 2024
1 task
jburns24
added a commit
to liatrio/liatrio-otel-collector
that referenced
this issue
Nov 8, 2024
* fix(deps): update tool deps * chore(deps): updated contrib and core modules to v0.113.0 * fix: Removed deprecated builder config value as it was removed in open-telemetry/opentelemetry-collector#11405 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Joshua Burns <[email protected]>
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this issue
Nov 21, 2024
…y#11568) Updates open-telemetry#11405 Signed-off-by: Bogdan Drutu <[email protected]>
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this issue
Nov 21, 2024
…config (open-telemetry#11588) Fixes open-telemetry#11405 Signed-off-by: Bogdan Drutu <[email protected]>
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this issue
Dec 19, 2024
…y#11568) Updates open-telemetry#11405 Signed-off-by: Bogdan Drutu <[email protected]>
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this issue
Dec 19, 2024
…config (open-telemetry#11588) Fixes open-telemetry#11405 Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One of the reason the mess with default providers (see #11403 or https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.109.0 or the need to disable strict check, see #11168) is the support of building older version of the collector with newer builder, which also is very fragile because it makes the assumption that the generated files (templates) will know how to talk to multiple versions. For this, because I believe this is not a very useful feature, but brings us a lot of troubles, already caused issues because we could not fix things simpler (for example to hardcode the versions for default confmap providers, etc.).
For this, we need to remove the config
otelcol_version
and always use the hardcoded "default_version".We already print an warning https://github.com/open-telemetry/opentelemetry-collector/blob/main/cmd/builder/internal/builder/main.go#L77
The text was updated successfully, but these errors were encountered: