Skip to content

Commit

Permalink
[chore][golangci-lint] Remove gosec excludes (#10411)
Browse files Browse the repository at this point in the history
#### Description
The upstream issue was fixed by
golangci/golangci-lint#4748, which was included
in release
[`v1.59.0`](https://github.com/golangci/golangci-lint/releases/tag/v1.59.0)
of `golangci-lint`. From local testing, we're pulling version `v1.59.0`
of `golangci-lint`, so the issue should be resolved.

Local runtime with excludes:
```
$ .tools/golangci-lint run -v --enable-only gosec
...
INFO Execution took 1.866075148s
INFO Execution took 1.218805785s
INFO Execution took 1.09527985s
```
Local runtime without excludes:
```
$ .tools/golangci-lint run -v --enable-only gosec
...
INFO Execution took 2.244716429s
INFO Execution took 1.539717296s
INFO Execution took 1.530163777s
```

Note: I ran `.tools/golangci-lint cache clean` between each test to
clean the cache and keep results as consistent as possible.

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes
#10213
  • Loading branch information
crobert-1 authored Jun 14, 2024
1 parent 42b61cc commit 48af1b8
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,6 @@ linters-settings:
files:
- "!**/*_test.go"

gosec:
excludes:
# https://github.com/open-telemetry/opentelemetry-collector/issues/10213
- G601
# https://github.com/open-telemetry/opentelemetry-collector/issues/10213
- G113

linters:
enable:
- depguard
Expand Down

0 comments on commit 48af1b8

Please sign in to comment.