Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failover connector to the contrib distribution #770

Merged

Conversation

douglascamata
Copy link
Contributor

The failsafe connector already exists in alpha state for all signals and even mentions in its README that it should be in both the contrib and k8s distributions. I'm not sure whether it truly needs to be in the k8s distribution, but I'm very certain it should be at least in the contrib one.

Correctly built with the ocb tool.

Fixes #701.

@douglascamata douglascamata requested a review from a team as a code owner December 11, 2024 11:27
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the component mentions k8s distro as well, shouldn't that be added for k8s as well?

Pinging @fatsheep9146 and @akats7 as code-owners of the component.

@douglascamata
Copy link
Contributor Author

@ChrsMark I'm not sure whether it should be there, that's why I didn't add it yet. I thought that maybe the README could be mentioning those two distributions because the contents were copied from a different component's README. 🤷

But if we all agree the failover connector should also be in the k8s distribution, I'm happy to swiftly add it there.

@povilasv
Copy link
Contributor

I think k8s distro already has it https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-k8s/manifest.yaml#L76 so only contrib is missing it? :)

@mx-psi
Copy link
Member

mx-psi commented Dec 12, 2024

Can we add a changelog note?

Signed-off-by: Douglas Camata <[email protected]>
@douglascamata
Copy link
Contributor Author

@mx-psi done. Thank you!

@mx-psi mx-psi added this pull request to the merge queue Dec 12, 2024
Merged via the queue into open-telemetry:main with commit 81e37fb Dec 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What are the plans regarding support of the failover connector in otelcol-k8s distribution
4 participants