Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linux package test healthcheck #622

Merged
merged 11 commits into from
Aug 28, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Aug 1, 2024

This PR

@mowies mowies changed the title add package test healthchecks add linux package test healthchecks Aug 1, 2024
mowies added 5 commits August 6, 2024 11:17
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies force-pushed the add-package-test-healthcheck branch from 17e1faf to 77d74a0 Compare August 6, 2024 09:17
mowies added 2 commits August 6, 2024 11:17
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies marked this pull request as ready for review August 6, 2024 09:47
@mowies mowies requested review from a team and djaglowski August 6, 2024 09:47
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies changed the title add linux package test healthchecks add linux package test healthcheck Aug 6, 2024
@cwegener
Copy link

cwegener commented Aug 23, 2024

Somehow is missed that this is now in a new repo!

The change makes sense to me. It's exactly what I had in mind.
I like the explicit use of podman exec.
It is the better option as opposed to the second option that I had considered which was to configure a Startup Health Check script.

The only improvement I could think of would be to write a very short blurb as a comment above the podman exec that concisely summarizes the reason why the podman exec is there (i.e. basically a short one-line summary of my original lengthy description)

(The reason for leaving a comment in-line would be because of the overall obscure nature of what is happening end-to-end in these tests. And the comment should help people who might not immediately see that the step from podman run to install deb/rpm is a very brittle piece that can easily fail in non-obvious ways)

@mowies
Copy link
Member Author

mowies commented Aug 26, 2024

@cwegener thanks for the feedback! i added a comment now, makes sense to me :)

Signed-off-by: Moritz Wiesinger <[email protected]>
@mx-psi mx-psi merged commit 2c0f59a into open-telemetry:main Aug 28, 2024
36 checks passed
@mowies mowies deleted the add-package-test-healthcheck branch August 28, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gh-actions] make linux package installation tests resilient to container image failures
3 participants