Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSI release #572

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Fix MSI release #572

merged 2 commits into from
Jun 10, 2024

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Jun 5, 2024

The wixl tool required to build the MSI package for Windows was only added to the CI workflows not to the release one.

This change restores the original MSI code from PR #560 and fixes the breaking issue with commit 9143b1e

The problem caused by the initial PR was reported at #560 (comment)

@pjanotti pjanotti requested review from a team and bryan-aguilar June 5, 2024 14:37
@jpkrohling
Copy link
Member

@pjanotti, are you able to test this change on a repository under your account? If you give me permissions on your fork, I can add the license key as env var temporarily to it.

@pjanotti
Copy link
Contributor Author

pjanotti commented Jun 7, 2024

@jpkrohling I'll follow up on Slack via DM.

@pjanotti
Copy link
Contributor Author

pjanotti commented Jun 8, 2024

Release validated on my fork, thanks @jpkrohling. I disabled docker to avoid the pushing docker images since it was going to fail. Results: https://github.com/pjanotti/opentelemetry-collector-releases/releases

Key jobs:

@jpkrohling
Copy link
Member

@mx-psi, if you have ideas for further verification, please let us know. Otherwise, I'll merge this towards the middle of the week.

@mx-psi
Copy link
Member

mx-psi commented Jun 10, 2024

Nothing specific for this PR, feel free to merge if you think it is ready :)

@jpkrohling jpkrohling merged commit 414594f into open-telemetry:main Jun 10, 2024
31 checks passed
@jpkrohling
Copy link
Member

I'll port these changes to my own distributions repo and see how it goes!

@jpkrohling
Copy link
Member

Apparently, it worked: https://github.com/jpkrohling/otelcol-distributions/releases/tag/v0.102.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants