-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MSI release #572
Fix MSI release #572
Conversation
@pjanotti, are you able to test this change on a repository under your account? If you give me permissions on your fork, I can add the license key as env var temporarily to it. |
@jpkrohling I'll follow up on Slack via DM. |
Release validated on my fork, thanks @jpkrohling. I disabled Key jobs: |
@mx-psi, if you have ideas for further verification, please let us know. Otherwise, I'll merge this towards the middle of the week. |
Nothing specific for this PR, feel free to merge if you think it is ready :) |
I'll port these changes to my own distributions repo and see how it goes! |
Apparently, it worked: https://github.com/jpkrohling/otelcol-distributions/releases/tag/v0.102.3 |
The wixl tool required to build the MSI package for Windows was only added to the CI workflows not to the release one.
This change restores the original MSI code from PR #560 and fixes the breaking issue with commit 9143b1e
The problem caused by the initial PR was reported at #560 (comment)