Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace datadog-agent dependecy versions #386

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Aug 11, 2023

Pins datadog-agent dependency versions to v0.48.0-beta.1 to adapt breaking changes. Same as open-telemetry/opentelemetry-collector-contrib#25102.

@songy23 songy23 added the dependencies Pull requests that update a dependency file label Aug 11, 2023
@songy23 songy23 requested review from mx-psi and a team August 11, 2023 20:14
@songy23
Copy link
Member Author

songy23 commented Aug 11, 2023

Needs to wait for v0.83. cc @mx-psi

@mx-psi
Copy link
Member

mx-psi commented Aug 14, 2023

CC @djaglowski @dmitryax this patch may be needed for the v0.83.0 release

@djaglowski
Copy link
Member

I cut the release without this override but I believe it should be possible to release a patch with only this change. Let me know how you'd like to proceed. @songy23

@songy23
Copy link
Member Author

songy23 commented Aug 15, 2023

@djaglowski IIUC this manifest file is for users to try out contrib components, they may still need the replace statement or they can run into dependency issues. I think merging this PR to mainline should be enough, I don't see a need to cut a patch release unless I'm missing something.

@djaglowski djaglowski merged commit bfa247c into open-telemetry:main Aug 15, 2023
@songy23 songy23 deleted the dd-agent-deps branch August 15, 2023 16:43
songy23 added a commit that referenced this pull request Oct 10, 2023
mx-psi pushed a commit that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants