Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use chmod flag during COPY #212

Merged
merged 2 commits into from
Oct 18, 2022
Merged

feat: use chmod flag during COPY #212

merged 2 commits into from
Oct 18, 2022

Conversation

greut
Copy link
Contributor

@greut greut commented Oct 6, 2022

The extra chmod step can be carried out by Docker itself. It requires buildkit mode to be on, but it's the case when using buildx.

@greut greut requested review from a team and Aneurysm9 October 6, 2022 12:12
@jpkrohling
Copy link
Member

Are you facing a specific problem leading to this change?

@greut
Copy link
Contributor Author

greut commented Oct 7, 2022

Not at all, as I've been rebuilding it locally for #204, this bit got me surprised and felt it was an opportunity to remove a comment pointing to an old issue, open-telemetry/opentelemetry-collector#1317

@jpkrohling
Copy link
Member

Before merging, can you positively confirm that you built an image with this new Dockerfile and it worked as expected?

@jpkrohling
Copy link
Member

@open-telemetry/collector-maintainers, @open-telemetry/collector-contrib-maintainer, this has the potential to break the release, but I believe it will not. In the worst case, the binaries in the generated images won't have the execute flag, preventing the binary from running.

In any case, my message to the next person in line to perform the release (@dmitryax?): keep this issue in mind if anything fails during the release process.

@jpkrohling jpkrohling merged commit 08b1607 into open-telemetry:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants