Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support for linux/pp64le arch #156

Merged
merged 1 commit into from
Jul 13, 2022
Merged

adding support for linux/pp64le arch #156

merged 1 commit into from
Jul 13, 2022

Conversation

adilhusain-s
Copy link
Contributor

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 1, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@adilhusain-s adilhusain-s mentioned this pull request Jul 6, 2022
Closed
@adilhusain-s adilhusain-s reopened this Jul 7, 2022
@adilhusain-s adilhusain-s marked this pull request as ready for review July 7, 2022 10:50
@adilhusain-s adilhusain-s requested review from a team and mx-psi July 7, 2022 10:50
jpkrohling
jpkrohling requested changes Jul 7, 2022
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm blocking the merge of this until we have this platform as part of the CI for core and contrib first.

@adilhusain-s adilhusain-s requested a review from jpkrohling July 7, 2022 19:41
@adilhusain-s
Copy link
Contributor Author

since the PR of collector-core is already merged and collector-contrib is in progress, could we also start working on this PR?

collector-core PR link
collector-contrib PR link

@adilhusain-s
Copy link
Contributor Author

please run the workflows.

@adilhusain-s
Copy link
Contributor Author

Please review and merge.

@adilhusain-s
Copy link
Contributor Author

@djaglowski
since collector-core and collector-contrib have been added in to CICD, could we also merge this PR?
please suggest any changes if required.

@djaglowski
Copy link
Member

@jpkrohling, please confirm your request has been addressed.

jpkrohling
jpkrohling approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is ready to be merged.

@jpkrohling jpkrohling merged commit dcaae02 into open-telemetry:main Jul 13, 2022
dmitryax pushed a commit to dmitryax/opentelemetry-collector-releases that referenced this pull request Jul 21, 2022
@adilhusain-s @dmitryax
Revert "adding support for linux/ppc64le arch (open-telemetry#156)"
3d1d6dd 
This reverts commit dcaae02.
dmitryax added a commit that referenced this pull request Jul 21, 2022
@dmitryax
Revert "adding support for linux/ppc64le arch (#156)" (#171)
f18e3c0 
This reverts commit dcaae02.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adilhusain-s @djaglowski @jpkrohling @mx-psi