Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nop exporter to distributions #564

Closed
jpkrohling opened this issue May 30, 2024 · 3 comments · Fixed by #566
Closed

Add nop exporter to distributions #564

jpkrohling opened this issue May 30, 2024 · 3 comments · Fixed by #566
Assignees

Comments

@jpkrohling
Copy link
Member

While profiling the distributions, it's useful to use the nop exporter, as it does even less than the debug exporter.

@jpkrohling
Copy link
Member Author

@TylerHelmuth , I came across this while profiling the k8s image.

@jpkrohling jpkrohling self-assigned this May 30, 2024
jpkrohling added a commit to jpkrohling/opentelemetry-collector-releases that referenced this issue May 30, 2024
Fixes open-telemetry#564

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@TylerHelmuth
Copy link
Member

I was under the impression that the nopexporter existed for testing, not for actual distribution.

@evan-bradley
Copy link
Contributor

It's useful for profiling the Collector since it removes nearly all exporting overhead. I think it's useful in pretty much all distributions for this purpose.

Paired with the nopreceiver, it could also be useful to start the Collector with only extensions running, which is particularly useful for remote config and hot-reloading. But seeing as these aren't commonly available with upstream components, I think this case could be considered later.

jpkrohling added a commit that referenced this issue May 30, 2024
* Add nop exporter to distributions
Fixes #564

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

* add nop exporter as exception to the readme

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

---------

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants