Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/elasticsearch] Use metrics builder for resource metrics #9757

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented May 5, 2022

This change refactors the receiver to rely more on generated code.

The only functional change:
Metrics scope name is changed from otelcol/elasticsearch to otelcol/elasticsearchreceiver

@dmitryax dmitryax requested a review from a team May 5, 2022 18:45
@dmitryax dmitryax requested a review from djaglowski as a code owner May 5, 2022 18:45
This change refactors the receiver to rely more on generated code.

The only functional change:
Metrics scope name is changed from `otelcol/elasticsearch` to `otelcol/elasticsearchreceiver`
@dmitryax dmitryax force-pushed the refactor-elasticsearch-receiver branch from ae51bf3 to fc0c4ea Compare May 5, 2022 18:46
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djaglowski djaglowski merged commit 8bf3d83 into open-telemetry:main May 5, 2022
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
…en-telemetry#9757)

This change refactors the receiver to rely more on generated code.

The only functional change:
Metrics scope name is changed from `otelcol/elasticsearch` to `otelcol/elasticsearchreceiver`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants