Update Prometheus to not have memory leak. #9718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
requested review from
Aneurysm9,
dashpole,
dmitryax,
jpkrohling and
alolita
as code owners
dashpole
approved these changes
May 3, 2022
Prometheus started doing proper go.mod publishing and started off with v0.35, but this means the previous version was "winning" as it was v1.8.2 so I had to update the version everywhere. This brings in prometheus/prometheus#10636 which fixes open-telemetry#9278 Signed-off-by: Goutham Veeramachaneni <[email protected]>
gouthamve
force-pushed
the
update-prom-no-memory-issue
branch
from
730905e to
a636b41
Compare
codeboten
approved these changes
May 3, 2022
dmitryax
reviewed
May 3, 2022
Signed-off-by: Goutham Veeramachaneni <[email protected]>
dmitryax
approved these changes
May 3, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
* Update Prometheus to not have memory leak. Prometheus started doing proper go.mod publishing and started off with v0.35, but this means the previous version was "winning" as it was v1.8.2 so I had to update the version everywhere. This brings in prometheus/prometheus#10636 which fixes open-telemetry#9278 Signed-off-by: Goutham Veeramachaneni <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus started doing proper go.mod publishing and started off with
v0.35, but this means the previous version was "winning" as it was v1.8.2
so I had to update the version everywhere.
This brings in prometheus/prometheus#10636
which fixes #9278
Signed-off-by: Goutham Veeramachaneni [email protected]