-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core to v0.2.3 #96
Merged
tigrannajaryan
merged 1 commit into
open-telemetry:master
from
tigrannajaryan:feature/tigran/updatedep
Jan 15, 2020
Merged
Update core to v0.2.3 #96
tigrannajaryan
merged 1 commit into
open-telemetry:master
from
tigrannajaryan:feature/tigran/updatedep
Jan 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia and
songy23
as code owners
January 15, 2020 00:17
pjanotti
reviewed
Jan 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo on the Makefile but other than that LGTM
tigrannajaryan
force-pushed
the
feature/tigran/updatedep
branch
from
January 15, 2020 00:22
bee12ae
to
6aaa0ea
Compare
pjanotti
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
owais
approved these changes
Jan 15, 2020
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
Added a Sleep to work around a data race bug in Jaeger (jaegertracing/jaeger#1625) caused by stopping immediately after starting. Without this Sleep we were observing this bug on our side: open-telemetry/opentelemetry-collector#43 The Sleep ensures that Jaeger Start() is fully completed before we call Jaeger Stop(). TODO: Jaeger bug is already fixed, remove this once we update Jaeger to latest version. Testing done: make test
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* add exported value for traceOptionBitMaskUnused (for testing) * move key_test to package core_test * add span_context_test to package core_test
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Move instrumentation asyncpg
jj22ee
pushed a commit
to jj22ee/opentelemetry-collector-contrib
that referenced
this pull request
Sep 22, 2023
* tweaks for enhanced container insights metrics * run go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.