[processor/transform] Add support for functions to validate parameters #9563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
changed the title
anuraaga
approved these changes
Apr 28, 2022
|
The |
|
@open-telemetry/collector-contrib-approvers please review. |
codeboten
approved these changes
May 5, 2022
codeboten
added
the
ready to merge
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
open-telemetry#9563) * Add support for functions to return errors * update test name * Updated changelog * Updated changelog Co-authored-by: Alex Boten <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the ability for functions to return errors. Although no functions need to yet, this capability will allow function creators to validate input parameters before returning the ExprFunc.
Link to tracking Issue:
#9555
Testing:
Added new unit tests