[receiver/riak] - Fix issue where user configured metric settings were ignored #9561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehaansa
reviewed
Apr 29, 2022
dehaansa
approved these changes
Apr 29, 2022
djaglowski
reviewed
May 2, 2022
There was a problem hiding this comment.
@armstrmi, a couple minor points of feedback. Also, please note that issues and pull requests in this repository should be titled as [receiver/riak] - Fix issue where user configured metric settings were ignored
armstrmi
changed the title
djaglowski
reviewed
May 2, 2022
djaglowski
reviewed
May 2, 2022
djaglowski
approved these changes
May 2, 2022
djaglowski
added a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…e ignored (open-telemetry#9561) * empty commit * empty commit * quick fix for newScraper method, e.g. no default * added missing dependencies * make gotidy * added changelog * empty commit, relaunch flaky test * empty commit, rerun tests * added scraper test with some metrics disabled * cleaned up unnecessary tests * implemented recommended changes * removed metricsDisabled boolean from scraper_test * implemented feedback * removed space after newline Co-authored-by: Daniel Jaglowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixing minor bug, issue with Riak receiver newScraper method, would only implement
DefaultMetricSettingsLink to tracking Issue:
(#9560)
Testing:
Documentation: