[processor/transform] Add ability to truncate attributes #9546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
reviewed
Apr 27, 2022
mx-psi
approved these changes
Apr 27, 2022
anuraaga
approved these changes
Apr 28, 2022
pmm-sumo
approved these changes
Apr 28, 2022
codeboten
reviewed
May 3, 2022
There was a problem hiding this comment.
Thanks for the improvement @TylerHelmuth, just a couple of questions
codeboten
approved these changes
May 3, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…try#9546) * Add truncation function * Add TODO * Updated changelog * Updated changelog * Update name to truncateAll * Fixed README * added checked for negative limit * Update changelog * Updated exposed function name as truncate_all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds to the transform processor the ability to truncate string values in maps. The intended goal being the ability to truncate string values on attributes and resource.attributes.
Link to tracking Issue:
#9366
This is one of two PR I plan to submit for this issue.
Testing:
Added unit tests and tested locally running the collector and tracegen
Documentation:
Updated README