[receiver/kubeletstats] refactor receiver to explicitly detail metrics emited. #9517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Apr 26, 2022
dmitryax
reviewed
Apr 27, 2022
dmitryax
approved these changes
Apr 30, 2022
|
@dmitryax is this ready to merge? |
dmitryax
added
the
ready to merge
|
Yes it is. added the right label :) cc @open-telemetry/collector-contrib-approvers |
pmm-sumo
approved these changes
May 3, 2022
codeboten
approved these changes
May 3, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…s emited. (open-telemetry#9517) * Update metadata.yaml to list all metrics * Updated accumulator to use new metrics * Fix import * Fix lint * Moved init functions into Types * Fix lint * Fix lint * run goporto * re-enabled volume metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates the kubletstats receiver's metadata.yaml to explicitly list the metrics this receiver exports. This also updates the documentation.yaml to now list all metrics emitted exactly as they are emitted.
No functionality change; the metrics emitted should be the same as before.
Link to tracking Issue:
#9413
Testing:
Ran all existing unit tests. Expected outcomes of the tests did not change since no metrics/attributes were changed.
Documentation:
automated documentation updated.