Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core dependency and adapt the code #9389

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Update core dependency and adapt the code #9389

merged 1 commit into from
Apr 21, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Apr 21, 2022 •
edited
Loading

  • pmetric.MetricValueType -> pmetric.NumberDataPointValueType and pmetric.ExemplarValueType

Deprecated usage of configunmarshaler will be handled separately

@dmitryax dmitryax requested a review from a team April 21, 2022 01:42
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 21, 2022
@dmitryax dmitryax force-pushed the updatedepcore branch 3 times, most recently from 976a461 to 4966037 Compare April 21, 2022 03:25
@dmitryax dmitryax mentioned this pull request Apr 21, 2022
Merged
@dmitryax dmitryax force-pushed the updatedepcore branch 3 times, most recently from 6ee7776 to f0cdeff Compare April 21, 2022 06:28
mx-psi
mx-psi previously approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with the other huge PR: I had a look at a few files at random and they look good, but I haven't checked all 566 files for my own sanity

@mx-psi mx-psi dismissed their stale review April 21, 2022 07:54

Lint is failing

@bogdandrutu
Copy link
Member

Please rebase and fix lint.

@dmitryax dmitryax force-pushed the updatedepcore branch 4 times, most recently from 394354c to 7abbdde Compare April 21, 2022 19:49
@dmitryax
Update core dependency and adopt the code
119d846 
- pmetric.MetricValueType -> pmetric.NumberDataPointValueType and pmetric.ExemplarValueType
@bogdandrutu bogdandrutu changed the title Update core dependency and adopt the code Update core dependency and adapt the code Apr 21, 2022
@bogdandrutu bogdandrutu merged commit 6f9ff1e into open-telemetry:main Apr 21, 2022
@dmitryax dmitryax deleted the updatedepcore branch April 21, 2022 23:18
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request Apr 22, 2022
@dmitryax @djaglowski
Update core dependency and adopt the code (open-telemetry#9389)
867f766 
- pmetric.MetricValueType -> pmetric.NumberDataPointValueType and pmetric.ExemplarValueType
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@mx-psi mx-psi mx-psi left review comments

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@pmm-sumo pmm-sumo Awaiting requested review from pmm-sumo

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@anuraaga anuraaga Awaiting requested review from anuraaga

@punya punya Awaiting requested review from punya

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@arminru arminru Awaiting requested review from arminru

@alolita alolita Awaiting requested review from alolita

Assignees

@jpkrohling jpkrohling

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitryax @bogdandrutu @mx-psi @jpkrohling