[receiver/prometheus] Validate that combined metrics all have the same timestamp #9385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @open-telemetry/wg-prometheus |
|
Is there a unit test for the new functionality? |
Added. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
djaglowski
approved these changes
Jun 20, 2022
TylerHelmuth
approved these changes
Jun 20, 2022
TylerHelmuth
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If Prometheus histogram points and summary points have timestamps set, those must be the same across metric points that we join together. Otherwise, it is possibly an inconsistent snapshot of the underlying histogram (e.g. prometheus/docs#514), and we should drop it to be safe.
Testing:
Fixed unit tests that were testing with invalid Prometheus series.