[processors/resourcedetection] Wire docker detector in processor factory #9372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mx-psi I think you were adding docker detector originally, could you take a look? :) Thank you! |
pmm-sumo
force-pushed
the
processor/resourcedetection/docker-fix
branch
from
ed140a9 to
f7be83a
Compare
pmm-sumo
changed the title
mx-psi
approved these changes
Apr 20, 2022
codeboten
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Wires docker detector in resourcedetectionprocessor
Link to tracking Issue: #9371
Testing: Unit test extended with verifying if all specified detectors can be created. Manually tested that collector starts with docker detector enabled
Documentation: N/A