-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/activedirectoryds] Add Active Directory Domain Services metrics receiver #9359
[receiver/activedirectoryds] Add Active Directory Domain Services metrics receiver #9359
Conversation
eec0289
to
a88cc11
Compare
If I want to make a change to this receiver, what should I do to validate that I have not broken something? |
@djaglowski On the system you want to test on (Windows Server 2012 R2+) - Install go + git Install-windowsfeature -name AD-Domain-Services -IncludeManagementTools
# Local administrator requires a password for installation, otherwise the next step will fail,
# so set the Admin password if necessary:
# net user Administrator P@ssw0rd!
# Install the forest; Note that the -SafeModeAdministratorPassword is set to P@ssw0rd! in this instance, and isn't secure
Install-ADDSForest -InstallDns -DomainName test.example.com -DomainNetBIOSName TEST -SafeModeAdministratorPassword (ConvertTo-SecureString -String "P@ssw0rd!" -AsPlainText -Force) -NoRebootOnCompletion -Force After this step, a reboot is required. The After reboot, the integration test can be run with go test at the root of the cloned repo: go test -tags=integration github.com/open-telemetry/opentelemetry-collector-contrib/receiver/activedirectorydsreceiver/... As explained above, the problem is that reboot step. I've looked into windows containers, but it has a similar issue. The only way I can think is possibly running a VM to test, but that has a few issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BinaryFissionGames, thanks for the detailed description of how to create a test system.
It seems that a true integration test is not realistic for this receiver. However, I would like to explore the idea of creating a simple simulator, rather than relying on "manual" mocking and testing. Please see other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @BinaryFissionGames
Description:
Adds the
active_directory_ds
metrics receiver, which scrapes metrics about a running Active Directory Domain Services instance.Link to tracking Issue: #8833
Testing:
Documentation: