Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs transform processor #9335

Merged
merged 44 commits into from
May 5, 2022

Conversation

dehaansa
Copy link
Contributor

Description: Add a processor for leveraging the opentelemetry-log-collection operators even if the logs are not coming in through a logs receiver that leverages the opentelemetry-log-collection library.

Link to tracking Issue: #9133

Testing: Unit tests for both the new converter to convert from pdata.Logs -> []entry.Entry and for the transform processor.

@dehaansa dehaansa requested a review from a team April 16, 2022 01:54
internal/stanza/frompdataconverter.go Outdated Show resolved Hide resolved
internal/stanza/frompdataconverter.go Outdated Show resolved Hide resolved
internal/stanza/frompdataconverter.go Show resolved Hide resolved
internal/stanza/frompdataconverter.go Show resolved Hide resolved
internal/stanza/storage.go Show resolved Hide resolved
processor/logstransformprocessor/config.go Outdated Show resolved Hide resolved
internal/stanza/frompdataconverter_test.go Show resolved Hide resolved
processor/logstransformprocessor/processor.go Outdated Show resolved Hide resolved
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from a code standpoint.

@dehaansa dehaansa requested a review from dmitryax as a code owner April 26, 2022 14:04
@djaglowski
Copy link
Member

@dehaansa, per conversation in today's SIG, this can move forward. Please rebase

@djaglowski djaglowski merged commit 5f60f1c into open-telemetry:main May 5, 2022
djaglowski added a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
* First pass frompdataconverter for stanza

* Create fromPdataConverter

* Current iteration of logs transform processor

* Commit updated factorytest

* Almost ready

* Continue iterating to try to resolve test issues with logs transform

* Update gomod

* Fix issues with failing to start pipeline

* Fix issue with trace flags conversion

* Fix tests

* Fix linter concern

* Add changelog & codeowner

* Add logs transform to versions

* Add link to logs processor readme

* Tiny update to readme

* update go sum files

* Update gomod

* Update processor test based on updates to opentelemetry-log-collection

* Update internal/stanza/frompdataconverter.go

Co-authored-by: Daniel Jaglowski <[email protected]>

* Address some PR feedback

* Fix missing default return

* Fix issue with fromconverter batch

* Re-fix issue with fromconverter batch

* Implement round trip test

* Fix round trip test

* Validate scope name where possible

* Mark processor as experimental

* Set observed time for pdata converter test

* Fix test's use of observedTime

* Address linter concerns

* Update internal/stanza/go.mod

Co-authored-by: Daniel Jaglowski <[email protected]>

* Revert "Update internal/stanza/go.mod"

This reverts commit fb1de19.

Co-authored-by: Daniel Jaglowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants