-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs transform processor #9335
Merged
djaglowski
merged 44 commits into
open-telemetry:main
from
observIQ:stanza-operators-processor
May 5, 2022
Merged
Logs transform processor #9335
djaglowski
merged 44 commits into
open-telemetry:main
from
observIQ:stanza-operators-processor
May 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Apr 18, 2022
Co-authored-by: Daniel Jaglowski <[email protected]>
djaglowski
reviewed
Apr 22, 2022
djaglowski
reviewed
Apr 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me from a code standpoint.
@dehaansa, per conversation in today's SIG, this can move forward. Please rebase |
djaglowski
reviewed
May 5, 2022
Co-authored-by: Daniel Jaglowski <[email protected]>
This reverts commit fb1de19.
djaglowski
approved these changes
May 5, 2022
djaglowski
added a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
* First pass frompdataconverter for stanza * Create fromPdataConverter * Current iteration of logs transform processor * Commit updated factorytest * Almost ready * Continue iterating to try to resolve test issues with logs transform * Update gomod * Fix issues with failing to start pipeline * Fix issue with trace flags conversion * Fix tests * Fix linter concern * Add changelog & codeowner * Add logs transform to versions * Add link to logs processor readme * Tiny update to readme * update go sum files * Update gomod * Update processor test based on updates to opentelemetry-log-collection * Update internal/stanza/frompdataconverter.go Co-authored-by: Daniel Jaglowski <[email protected]> * Address some PR feedback * Fix missing default return * Fix issue with fromconverter batch * Re-fix issue with fromconverter batch * Implement round trip test * Fix round trip test * Validate scope name where possible * Mark processor as experimental * Set observed time for pdata converter test * Fix test's use of observedTime * Address linter concerns * Update internal/stanza/go.mod Co-authored-by: Daniel Jaglowski <[email protected]> * Revert "Update internal/stanza/go.mod" This reverts commit fb1de19. Co-authored-by: Daniel Jaglowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add a processor for leveraging the opentelemetry-log-collection operators even if the logs are not coming in through a logs receiver that leverages the opentelemetry-log-collection library.
Link to tracking Issue: #9133
Testing: Unit tests for both the new converter to convert from pdata.Logs -> []entry.Entry and for the transform processor.