-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[github-actions] Install tools instead of relying on cache #9276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to remove the tool cache here? I've seen issues w/ the tools cache before
I think so, certainly if we're going to install tools every time anyways. |
c7807d4
to
352db03
Compare
352db03
to
34a702c
Compare
I think caching is still helpful to reduce the CI time. Did you try to look what's the reason for the latest failures? I can look into that as well |
I've not been able to pin down the reason that caching started failing. It certainly seems worth getting to the bottom of though, since it will help us make an informed decision about whether to restore it or not. Help is certainly welcome. |
I've opened #9280 to track the need to determine the cause of caching failure, but I recommend we move forward with merging this fix in order to unblock development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the past, I've updated dependencies in the internal/tools
directory to force a rebuild of the tools cache. I can't remember if we ever got to the bottom of why this happens though.
See #9281
I'm not sure merging this PR is needed at this point. Looks like it's recovered already. We can keep the PR until the next incident, if the root cause is not fixed by that time we can merge it? |
Closing in favor of #9281 |
No description provided.