Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github-actions] Install tools instead of relying on cache #9276

Closed

Conversation

djaglowski
Copy link
Member

No description provided.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to remove the tool cache here? I've seen issues w/ the tools cache before

@djaglowski
Copy link
Member Author

Would it make sense to remove the tool cache here? I've seen issues w/ the tools cache before

I think so, certainly if we're going to install tools every time anyways.

@djaglowski djaglowski force-pushed the always-install-tools branch from c7807d4 to 352db03 Compare April 14, 2022 16:02
@djaglowski djaglowski force-pushed the always-install-tools branch from 352db03 to 34a702c Compare April 14, 2022 16:19
@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 14, 2022
@djaglowski djaglowski added the ci-cd CI, CD, testing, build issues label Apr 14, 2022
@djaglowski djaglowski changed the title Install tools regardless of previous caching [github-actions] Install tools instead of relying on cache Apr 14, 2022
@dmitryax
Copy link
Member

I think caching is still helpful to reduce the CI time. Did you try to look what's the reason for the latest failures? I can look into that as well

@djaglowski djaglowski marked this pull request as ready for review April 14, 2022 17:00
@djaglowski djaglowski requested review from a team and mx-psi April 14, 2022 17:00
@djaglowski
Copy link
Member Author

I've not been able to pin down the reason that caching started failing. It certainly seems worth getting to the bottom of though, since it will help us make an informed decision about whether to restore it or not. Help is certainly welcome.

@djaglowski
Copy link
Member Author

I've opened #9280 to track the need to determine the cause of caching failure, but I recommend we move forward with merging this fix in order to unblock development.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past, I've updated dependencies in the internal/tools directory to force a rebuild of the tools cache. I can't remember if we ever got to the bottom of why this happens though.

See #9281

@dmitryax
Copy link
Member

I'm not sure merging this PR is needed at this point. Looks like it's recovered already. We can keep the PR until the next incident, if the root cause is not fixed by that time we can merge it?

@djaglowski
Copy link
Member Author

I'll close this PR because #9281 appears to have solved it, but I don't believe it resolved on its own. #9279 still presents the problem, which I believe is the newest PR excluding Alex's fix. PRs opened prior to the issue emerging appear to have continued working.

@djaglowski
Copy link
Member Author

Closing in favor of #9281

@djaglowski djaglowski closed this Apr 14, 2022
@djaglowski djaglowski deleted the always-install-tools branch April 14, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants