[receiver/sqlserver] Add SQL Server Metrics Receiver #9252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKurek
force-pushed
the
sqlserver_receiver
branch
from
8be9f85 to
ad57820
Compare
djaglowski
reviewed
Apr 13, 2022
|
Some formatting checks are failing. These make targets should help debug locally. |
StefanKurek
force-pushed
the
sqlserver_receiver
branch
5 times, most recently
from
891c367 to
79c7082
Compare
djaglowski
reviewed
Apr 15, 2022
There was a problem hiding this comment.
Looks quite good, just a few minor things to tidy up.
Noting that Installing SQL Server adds 6 minutes to the build-and-test-windows workflow. I think this is a reasonable cost for the benefit of being able to run real tests for this receiver. It doesn't currently extend the total CI runtime at this point either, because parallel workflows such as build-and-test are running multiple times longer. If this workflow becomes the critical path for CI, it can be split apart such that tests requiring installation steps run on a parallel job.
StefanKurek
force-pushed
the
sqlserver_receiver
branch
from
79c7082 to
848205c
Compare
djaglowski
reviewed
Apr 15, 2022
StefanKurek
force-pushed
the
sqlserver_receiver
branch
from
848205c to
a5a43de
Compare
This makes use of the windowsperfcounter watchers, using them to collect SQL Server metrics.
StefanKurek
force-pushed
the
sqlserver_receiver
branch
from
a5a43de to
e29e231
Compare
djaglowski
approved these changes
Apr 15, 2022
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add SQL Server Metrics receiver using windows performance counter as a base.
Link to tracking Issue:
#8398
Testing:
Added config testing, factory tests, and scraper unit tests to validate new code.
An integration test has been added (and was tested locally) to verify the receiver can collect metrics, but I am expecting it to not work in this pipeline off the bat as I don't think SQL Server is installed on the Windows machines provided by GitHub Actions. And I'm not sure if we want to change the behavior of the pipeline to install SQL Server every time.
Documentation:
Added doc explaining use of receiver.