Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core dependency and adopt to its API changes #9231

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Update core dependency and adopt to its API changes #9231

merged 1 commit into from
Apr 13, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Apr 12, 2022 •
edited
Loading

Switch from using model/pdata package to the new packages split by signal type

Deprecations from open-telemetry/opentelemetry-collector#4936 will be addressed separately

@dmitryax dmitryax requested a review from a team April 12, 2022 16:42
@dmitryax dmitryax marked this pull request as draft April 12, 2022 16:42
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 12, 2022
@codeboten
Copy link
Contributor

😰
Screen Shot 2022-04-12 at 9 53 55 AM

@dmitryax dmitryax force-pushed the updatecoredep branch 12 times, most recently from 29b3283 to a72bc0d Compare April 12, 2022 23:40
@dmitryax dmitryax marked this pull request as ready for review April 13, 2022 00:14
@dmitryax
Copy link
Member Author

@codeboten 1051 now 😆

@dmitryax
Copy link
Member Author

dmitryax commented Apr 13, 2022 •
edited
Loading

@open-telemetry/collector-contrib-approvers it's ready for review now 😅

mx-psi
mx-psi reviewed Apr 13, 2022
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even Github struggles loading this PR 😄

cmd/configschema/go.mod Show resolved Hide resolved
mx-psi
mx-psi approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to check a thousand files, so I only did a sanity check that the changes make sense.

If you used a script for this or if you think there is any file that merits special attention, I am happy to review that :)

@dmitryax
Copy link
Member Author

Thanks @mx-psi.

This is mostly what I've done:

  1. sed replacements
  2. cleaning up lint issues

@dmitryax
Update core dependency and adopt to its API changes
f86e95e 
Switch from using model/pdata package to the new packages split by signal type
djaglowski
djaglowski approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at many files randomly and all changes looked good.

codeboten
codeboten approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a diff at the command line w/ origin/main and grepped through the changes. It looks good as far as i can tell.

@codeboten codeboten merged commit 9c214be into open-telemetry:main Apr 13, 2022
@dmitryax dmitryax deleted the updatecoredep branch April 13, 2022 21:06
@dmitryax dmitryax mentioned this pull request Apr 13, 2022
Merged
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@djaglowski djaglowski djaglowski approved these changes

@codeboten codeboten codeboten approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@pmm-sumo pmm-sumo Awaiting requested review from pmm-sumo

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@anuraaga anuraaga Awaiting requested review from anuraaga

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@punya punya Awaiting requested review from punya

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@arminru arminru Awaiting requested review from arminru

@alolita alolita Awaiting requested review from alolita

Assignees

@codeboten codeboten

@djaglowski djaglowski

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitryax @codeboten @djaglowski @mx-psi