Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test in jaegerremotesampling #9137

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

jpkrohling
Copy link
Member

Before this change, the test would intermittently fail with:

2022/04/11 13:42:07 FATAL: [core] grpc: Server.RegisterService after Server.Serve for "jaeger.api_v2.SamplingManager"
FAIL    github.com/open-telemetry/opentelemetry-collector-contrib/extension/jaegerremotesampling        0.028s

I was able to consistently reproduce it with:

$ go test -race -v -timeout 300s -count 1000 --tags=""  -run "^TestStartAndShutdownRemote$" ./...

After this PR, I wasn't able to reproduce this anymore.

Fixes #9113

Signed-off-by: Juraci Paixão Kröhling [email protected]

Fixes #9113

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling requested review from a team and dashpole April 11, 2022 16:43
@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 11, 2022
@pmm-sumo pmm-sumo added the ready to merge Code review completed; ready to merge by maintainers label Apr 11, 2022
@jpkrohling jpkrohling merged commit c78cb9e into open-telemetry:main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[extension/jaegerremotesampling] Flaky test - TestStartAndShutdownRemote
4 participants