[attributesprocessor] remove log names from filters #9131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
remove_log_names
branch
from
97078d4 to
b2805f2
Compare
atoulme
changed the title
atoulme
force-pushed
the
remove_log_names
branch
from
b2805f2 to
286ee0a
Compare
djaglowski
approved these changes
Apr 11, 2022
|
LGTM, but @pmm-sumo should also take a look as component owner. |
pmm-sumo
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Looks good. The configuration field was deprecated in v0.45. I think 4 versions should be enough for this feature to be considered removed
pmm-sumo
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove the log_names property matcher for logs, as log names are now obsolete.
Also, the log_names property is not used in actually filtering records, and therefore already not in use.
Link to tracking Issue:
No issue.
Testing:
No new tests. Deleting code only.
Documentation:
None - removed.