[receiver/windowsperfcountersreceiver] Create common package for windows performance counter receivers #9108
Conversation
receiver/windowsperfcountersreceiver/windowsperfcounters_scraper_test.go
Outdated
Show resolved
Hide resolved
receiver/windowsperfcountersreceiver/windowsperfcounters_scraper.go
Outdated
Show resolved
Hide resolved
| now := pdata.NewTimestampFromTime(time.Now()) | ||
| var errs error | ||
|
|
||
| metrics.EnsureCapacity(len(s.counters)) | ||
|
|
||
| metricSlice.EnsureCapacity(len(s.watchers)) |
There was a problem hiding this comment.
There is a problem here that we should address, but it can be a followup PR since it is not a regression.
We should not necessarily return a separate Metric instance for every counter, particularly when multiple counters represent data points that should belong to the same metric.
There was a problem hiding this comment.
It doesn't necessarily make a new metric for every counter. The maximum amount of metrics there could be are the amount of watchers so the capacity is that much.
There was a problem hiding this comment.
But it doesn't aggregate data points onto the same metric instance when appropriate, right?
There was a problem hiding this comment.
ah yeah, it doesn't when it's generated metrics but does when you define the metric. I'll clean it up in a seperate PR.
Description:
Move common code of windows performance counter receiver into separate package to enable building of specific windows technology scrapers without needing to embed the generic windowsperfcounterreceiver into those other receivers.
Link to tracking Issue:
N/A