Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core dependency and adopt to recent changes #8519

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Update core dependency and adopt to recent changes #8519

merged 1 commit into from
Mar 18, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Mar 16, 2022 •
edited
Loading

Changes to adopt pdata API renames:

  • pdata.AttributeValue(\w*) -> pdata.Value$1
  • pdata.NewAttributeValue(\w*) -> pdata.NewValue$1

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 16, 2022
@dmitryax dmitryax requested a review from a team March 16, 2022 20:18
@dmitryax
Copy link
Member Author

This should be merged after #8515

@dmitryax dmitryax marked this pull request as draft March 16, 2022 20:23
@dmitryax dmitryax force-pushed the update-core-pdata branch from be58ba9 to c5fd80a Compare March 16, 2022 23:23
@dmitryax dmitryax marked this pull request as ready for review March 16, 2022 23:23
@dmitryax dmitryax force-pushed the update-core-pdata branch 2 times, most recently from a8a1126 to 235db23 Compare March 17, 2022 04:29
mx-psi
mx-psi reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

@dmitryax
Update core dependency and adopt to recent changes
14dcf5a 
Changes to adopt pdata API renames:

- pdata.AttributeValue(\w*) -> pdata.Value$1
- pdata.NewAttributeValue(\w*) -> pdata.NewValue$1
@dmitryax dmitryax force-pushed the update-core-pdata branch from 235db23 to 14dcf5a Compare March 17, 2022 17:09
@dmitryax
Copy link
Member Author

@bogdandrutu @mx-psi PR is rebased

@codeboten codeboten merged commit b00283b into open-telemetry:main Mar 18, 2022
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@codeboten codeboten codeboten approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@pmm-sumo pmm-sumo Awaiting requested review from pmm-sumo

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@anuraaga anuraaga Awaiting requested review from anuraaga

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@punya punya Awaiting requested review from punya

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@arminru arminru Awaiting requested review from arminru

@alolita alolita Awaiting requested review from alolita

Assignees

@bogdandrutu bogdandrutu

@dashpole dashpole

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmitryax @codeboten @mx-psi @bogdandrutu @dashpole