[cmd/mdatagen] Fix optional metrics support #7166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
mdatagen-fix-enabled-metrics-field
branch
from
333ce86 to
787948b
Compare
djaglowski
approved these changes
Jan 13, 2022
codeboten
approved these changes
Jan 13, 2022
dmitryax
force-pushed
the
mdatagen-fix-enabled-metrics-field
branch
from
787948b to
27c32b1
Compare
Metrics defined with `enabled: false` flag in metadata.yaml supposed to be optional and not reported by metrics builder by default. There is a bug in metadata.yaml validation which doesn't allow zero value in Enabled field. This change fixes the bug by switching the Enabled field to a pointer type to keep the field required metadata.yaml but not enforce a non-zero value.
dmitryax
force-pushed
the
mdatagen-fix-enabled-metrics-field
branch
from
27c32b1 to
8ed8b8b
Compare
dmitryax
added
the
ready to merge
animetauren
pushed a commit
to animetauren/opentelemetry-collector-contrib
that referenced
this pull request
Apr 4, 2023
…etry#7166) It wasn't picked up because of the `.yml` (not `.yaml`) extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics defined with
enabled: falseflag in metadata.yaml supposed to be optional and not reported by metrics builder by default. There is a bug in metadata.yaml validation which doesn't allow zero value in Enabled field. This change fixes the bug by switching the Enabled field to a pointer type to keep the field required metadata.yaml but not enforce a non-zero value.Link to tracking Issue: open-telemetry/opentelemetry-collector#10904