[mdatagen] Refactor new metrics builder internal structures #6904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
changed the title
dmitryax
force-pushed
the
refactor-mdata-gen
branch
from
76bc564 to
d6f6712
Compare
djaglowski
approved these changes
Dec 20, 2021
dmitryax
force-pushed
the
refactor-mdata-gen
branch
from
d6f6712 to
d01abd1
Compare
Move metric specific logic from functions to internal metric struct methods. This encapsulation makes the logic of metrics builder cleaner and also allows future evolvement of user settings support.
dmitryax
force-pushed
the
refactor-mdata-gen
branch
from
d01abd1 to
b894035
Compare
bogdandrutu
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move metric specific logic from functions to internal metric struct methods. This encapsulation makes the metrics builder logic cleaner and also allows future evolvement of user settings support.
Link to tracking Issue: open-telemetry/opentelemetry-collector#10904