-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datadog] Compatibility with ECS Fargate semantic conventions #6670
[exporter/datadog] Compatibility with ECS Fargate semantic conventions #6670
Conversation
…unning metrics We do this because of two reasons: 1. we don't want to expose the Fargate hostname and 2. users care about identifying where their Collector is running (in this case which task).
Just a note, I have a absolutely had use cases in large Fargate clusters where one or two hosts went bad and the only way we caught it in DD was with hostname / ip based metrics we were gathering. This was a cluster of a few thousand tasks so a full re-deployment was out of the question. |
It's useful to know this, thanks! Here I am trying to do a reduced version of what the Datadog Agent does when setting the As it happens with the Datadog Agent, you can still get the hostname if you want: only if you use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment but LGTM overall
@jpkrohling this has been approved by a CODEOWNER. If you find the time today, could you review and, if it looks good, merge it? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wanted to double-check a specific conditional.
Description:
This adds compatibility with AWS ECS Fargate OpenTelemetry semantic conventions by
task_arn
to running metrics so that users can see which tasks are running the exporter.Previously, we already added
task_arn
automatically to tags/metadata; this is kept.Users of Fargate versions that don't have TMDE v4 or later, need to add the
aws.ecs.launchtype
semantic convention manually to payloads, e.g. by means of the resource attribute:Link to tracking Issue: n/a, customer request
Testing: Added unit tests, tested end to end by mocking:
Resource processor configuration for mocking AWS ECS Fargate