Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to change the data type (from int to float or vice-versa) #402

Conversation

james-bebbington
Copy link
Member

Link to tracking Issue: #332

Description:
Added an extension to the metric transform processor to allow changing the data type between int & float

@james-bebbington james-bebbington requested a review from a team July 7, 2020 04:06
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #402 into master will increase coverage by 20.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #402       +/-   ##
===========================================
+ Coverage   63.22%   84.11%   +20.89%     
===========================================
  Files          16      181      +165     
  Lines         677     9699     +9022     
===========================================
+ Hits          428     8158     +7730     
- Misses        225     1208      +983     
- Partials       24      333      +309     
Flag Coverage Δ
#integration 63.22% <ø> (ø)
#unit 83.91% <100.00%> (?)
Impacted Files Coverage Δ
...stransformprocessor/metrics_transform_processor.go 100.00% <100.00%> (ø)
exporter/sapmexporter/exporter.go 88.88% <0.00%> (ø)
...orter/signalfxexporter/metricdata_to_signalfxv2.go 88.57% <0.00%> (ø)
exporter/newrelicexporter/factory.go 68.42% <0.00%> (ø)
exporter/elasticexporter/factory.go 83.33% <0.00%> (ø)
receiver/signalfxreceiver/factory.go 94.11% <0.00%> (ø)
exporter/awsxrayexporter/factory.go 100.00% <0.00%> (ø)
exporter/splunkhecexporter/metricdata_to_splunk.go 74.48% <0.00%> (ø)
...eiver/k8sclusterreceiver/collection/replicasets.go 0.00% <0.00%> (ø)
...xporter/alibabacloudlogserviceexporter/uploader.go 100.00% <0.00%> (ø)
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df6a48...c400fa8. Read the comment docs.

@james-bebbington james-bebbington force-pushed the metrictransform-change-datatype branch 2 times, most recently from a2069b6 to ea25470 Compare July 7, 2020 04:29
@james-bebbington james-bebbington force-pushed the metrictransform-change-datatype branch from ea25470 to dd956c7 Compare July 7, 2020 23:51
@james-bebbington james-bebbington force-pushed the metrictransform-change-datatype branch from dd956c7 to c7881b9 Compare July 9, 2020 02:56
@james-bebbington james-bebbington force-pushed the metrictransform-change-datatype branch from c7881b9 to c400fa8 Compare July 10, 2020 06:13
@bogdandrutu bogdandrutu merged commit 554000d into open-telemetry:master Jul 10, 2020
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
bogdandrutu pushed a commit that referenced this pull request May 12, 2022
* Update changelog in preparation for release v0.25.0

* Fix copy/paste error
codeboten pushed a commit that referenced this pull request Nov 23, 2022
… given, otherwise use global tracer provider (#402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants