Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/mysql] Add delete_multi, update_multi to mysql.commands metric #37329

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[receiver/mysql] Add delete_multi, update_multi to mysql.commands metric #37329

merged 1 commit into from
Jan 21, 2025

Conversation

CodePrometheus
Copy link
Contributor

Description

Link to tracking issue

Fixes #37301

Testing

Documentation

@CodePrometheus CodePrometheus requested review from djaglowski and a team as code owners January 20, 2025 07:09
atoulme
atoulme approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @djaglowski should have final word

@djaglowski djaglowski merged commit c715b68 into open-telemetry:main Jan 21, 2025
165 checks passed
@CodePrometheus CodePrometheus deleted the add-more-commands-for-mysqlreceiver branch January 21, 2025 15:07
@github-actions github-actions bot added this to the next release milestone Jan 21, 2025
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
@CodePrometheus @chengchuanpeng
[receiver/mysql] Add delete_multi, update_multi to mysql.commands met…
1c9cac8 
…ric (open-telemetry#37329)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#37301

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@djaglowski djaglowski djaglowski approved these changes

Assignees

@evan-bradley evan-bradley

Labels
receiver/mysql
Projects
None yet
Milestone
v0.118.0
Development

Successfully merging this pull request may close these issues.

[receiver/mysq] Capture deletes and update across multiple tables
4 participants
@CodePrometheus @atoulme @djaglowski @evan-bradley